On Mon, 10 Nov 2025 13:12:57 GMT, Jaikiran Pai <[email protected]> wrote:
>> Oumaiyma Intissar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove invalid host check in HostPortrange
>>
>> Removed check for leading ':' in host authority.
>
> src/java.base/share/classes/java/net/HostPortrange.java line 65:
>
>> 63: // Defensive validation first
>> 64: if (host == null || host.isEmpty()) {
>> 65: throw new IllegalArgumentException("empty authority");
>
> Hello Oumaiyma, the change overall looks OK to me. However, this error
> message and the other one feel a bit odd. The variable is called `host` and
> we throw an "empty authority" here whereas the other place, the variable is
> called "authority" and we throw a error message which says "empty host".
>
> @dfuch do you suggest we switch these error messages?
We should probably throw the same exception here than below:
throw new IllegalArgumentException("Invalid URL authority: empty host");
If the authority is empty the host is a fortiori empty too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27896#discussion_r2511391270
