On Tue, 11 Nov 2025 12:58:04 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review for this fix which addresses a connection leak in > HttpClient when dealing with HTTP/2 requests? > > I have added a comment in https://bugs.openjdk.org/browse/JDK-8326498 which > explains what the issue is. The fix here addresses the issue by cleaning up > the `Http2Connection` closing logic and centralizing it to a connection > terminator. The terminator then ensures that the right resources are closed > (including the underlying SocketChannel) when the termination happens. > > A new jtreg test has been introduced which reproduces the issue and verifies > the fix. src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java line 912: > 910: * Closes the connection normally (with a NO_ERROR termination > cause), if not already closed. > 911: */ > 912: final void close() { Maybe we should mark the Http2Connection as Closeable. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2514204634
