On Wed, 19 Nov 2025 10:06:10 GMT, Michael McMahon <[email protected]> wrote:

>> @Michael-Mc-Mahon, very good (embarrassing :facepalm:) catch!
>> 
>> @dfuch, I guess `httpserver/HeadersTest.java` needs a serious overhaul 
>> against these kind of normalization edge cases. I will try tackling this 
>> tomorrow (CET). @SentryMan, let me know if you prefer picking this up 
>> yourself.
>
> The other issue you found at line 135 raises the question to _how_ strings 
> that don't start with a letter are normalized? (A) Do we only ever put the 
> first character as uppercase (if it's a letter)? Or (B) do we always put the 
> first letter in a string in uppercase, wherever it appears in the string? 
> 
> Looks like the current behavior is (A) and we should stick with that, from 
> the point of view of new tests. So, `2xyz` would be normalized as `2xyz`, but 
> `xyz2` would be normalized as `Xyz2`. Does that make sense?

@Michael-Mc-Mahon, your expectation is correct.

In 1a849f44c01, I've addressed the bug you've spotted, and also added tests for 
it. Would you mind re-reviewing the changes, please?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27276#discussion_r2545259584

Reply via email to