On Mon, 24 Nov 2025 21:00:08 GMT, Volkan Yazici <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup HttpClientImpl ctor
>> - Rename setParams
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java
> line 1:
>
>> 1: /*
>
> Thank you, this was a long-overdue clean up. 😍 I had an earlier attempt at
> this in `HttpClientImpl::new`, but did not dare to extend its scope — was
> told, _"There be dragons!"_ :rofl:
>
> Curious: can we also clean up `QuicClient::requireTLS13` too? Personally, I'm
> very much in favor of seeing only one occurrence of hardcoded `"TLSv1.2"` and
> `"TLSv1.3"` string literals.
That sounds like a larger change / cleanup. I'd rather not do it here.
> test/jdk/java/net/httpclient/http3/H3UnsupportedSSLParametersTest.java line
> 85:
>
>> 83: */
>> 84: @Test
>> 85: public void testDefault() throws Exception {
>
> This test passes even without your changes. Is this expected?
Yes that's expected. The check in the HttpClientImpl was correct already. This
just adds coverage.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28480#discussion_r2559427480
PR Review Comment: https://git.openjdk.org/jdk/pull/28480#discussion_r2559121009
