On Thu, 27 Nov 2025 10:03:29 GMT, Daniel Fuchs <[email protected]> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   fix duration overflow issue with Duration.toMillis()
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http3Connection.java 
> line 917:
> 
>> 915:             // in the pool (thus idle), then we instruct QUIC to 
>> generate traffic on the
>> 916:             // QUIC connection to prevent it from being idle terminated.
>> 917:             final boolean generateTraffic = this.presentInConnPool
> 
> I wonder if `this.presentInConnPool` can be replaced with `!this.finalStream`

Me and Daniel discussed about this and we decided to include a `!finalStream` 
check too. The PR has been updated with this change. The test continues to pass 
and I've triggered a CI run with these latest updates.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28522#discussion_r2571397973

Reply via email to