On Mon, 8 Dec 2025 19:25:23 GMT, Daniel Jeliński <[email protected]> wrote:

>> Currently the HttpUrlConnection throws a generic "Authentication failure" 
>> exception when authentication fails locally.
>> 
>> The authentication may fail for various reasons like: incorrect server 
>> challenge message, unavailable encryption/digest algorithms, encoding errors 
>> etc. The detailed failure information should be available to the user. 
>> Without it, the exception is next to impossible to diagnose, see 
>> [JDK-8347778](https://bugs.openjdk.org/browse/JDK-8347778) for example.
>> 
>> This PR adds the original exception as the cause of the "Authentication 
>> failure" exception.
>> 
>> The detailed exception messages are enabled by the "hostInfo" and 
>> "hostInfoExclSocket" categories of "jdk.includeInExceptions". Note that 
>> "hostInfoExclSocket" is enabled by default.
>> 
>> Added a new test to verify that the exception details are present when 
>> jdk.includeInExceptions includes hostInfoExclSocket (default), and absent 
>> otherwise. Existing tier1-3 tests continue to pass.
>
> Daniel Jeliński has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fail test if no exception is thrown

Any idea why `getHeaderValue` is not updated the same way? There are several 
places where the return value is set into a request. I have no memory of the 
details but it makes me feel uneasy.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28601#issuecomment-3629165171

Reply via email to