On Tue, 16 Dec 2025 10:25:04 GMT, EunHyunsu <[email protected]> wrote:

>> Thank you @ehs208 for these updates. The changes look good to me. I'll run 
>> the latest changes in our CI to make sure this continues to pass.
>> 
>> On a related note, have you run tier2 locally with these changes? The GitHub 
>> actions job only run tier1 and networking tests aren't covered in that. It 
>> would be good to run tier2 on your local setup too - that way any future 
>> contributions in this area can be tested locally to verify that changes 
>> don't break unexpected existing tests.
>
> @jaikiran I ran jdk_net tests locally. Results: 1047 passed, 1 failed.
> 
>   The failed test is `HTTPSetAuthenticatorTest` (HTTP/1.1 Authenticator test) 
> with `SocketException: Connection reset`, which appears to be a flaky test 
> unrelated to this PR's HTTP/2 GOAWAY changes. All HTTP/2 related tests passed 
> successfully.

Hello @ehs208, I'm investigating a intermittent test failure of the newly added 
test in our CI. I think the test will need a few adjustments. I haven't had a 
chance to go over the failure in its entirety. I will add some details here 
when I am done looking at that failure.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28632#issuecomment-3659837419

Reply via email to