On Tue, 27 Jan 2026 19:05:37 GMT, Daniel Fuchs <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Do not reset stream when read is interrupted
>
> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http3/Http3ServerStreamImpl.java
> line 337:
>
>> 335: ByteBuffer buffer = current();
>> 336: if (buffer == QuicStreamReader.EOF) {
>> 337: return -1;
>
> I don't think that's correct. If we get an error we set the error flag AND
> add EOF to the buffer list to unblock the reader. Therefore, you must check
> whether error == null before returning -1 - I believe you should restore
> lines 334-336 here.
I'm checking that in the `current()` method now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29448#discussion_r2735392441
