On Wed, 28 Jan 2026 21:16:01 GMT, Sean Mullan <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Force cache limit per compression algorithm > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 966: > >> 964: >> 965: /** >> 966: * Sets whether TLS certificate compression should be enabled. > > I think we should also specify what this enables, the name of the extension. > I would also add an @spec label with RFC 8879. Also consider adding a > sentence or two (perhaps as an API note) that this signals to the peer that > it supports compression and that both sides need to support the underlying > extension and compression format in order for it to be actually used. > > Also, I would probably add an Implementation Note specifying that the SunJSSE > provider only supports zlib compression, and that other JSSE providers may > not support this method. Done, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28682#discussion_r2739563146
