On Tue, 10 Feb 2026 15:03:26 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which removes the overriden >> `getCertificates()` and `getCodeSigners()` method implementations in >> `URLJarFile$URLJarFileEntry`? >> >> These overriden implementations were returning a cloned array, but as noted >> in https://bugs.openjdk.org/browse/JDK-8377338, these overrides are not >> needed because the corresponding methods in the `JarEntry` super class >> already return a cloned array. >> >> Existing tests in tier1, tier2 and tier3 continue to pass with this change. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - merge latest from master branch > - remove unused imports > - URLJarFile$URLJarFileEntry need not clone the arrays returned by > getCertificates() and getCodeSigners() Thank you Sean and Daniel for the reviews. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29600#issuecomment-3881720496
