On Tue, 24 Feb 2026 10:28:14 GMT, Daniel Fuchs <[email protected]> wrote:
>> Hi @dfuch , >> >> >> >> >> >> Thanks for the feedback. The issue was already filed so I assumed it was a >> valid problem to fix, but I didn't look closely enough at the existing code. >> After your comment I checked OpeningHandshake.proxyFor() and see that it >> already converts ws/wss to http/https before calling select(). >> >> >> Tomcat, Tyrus, OkHttp also all do the same conversion on the caller side. >> so this is the intended pattern, not a gap. Should I close this? > >> Should I close this? > > Yes please. I thought I had commented on that RFE already but can't find my > comment now. I should have closed i at the time - I remember I didn't do it > immediately because I was wondering what was the use case the submitter had > in mind. I am going to close that RFE now. Sorry for the inconvenience. I > will let you withdraw the associated CSR. > > As a matter of policy when picking up on a RFE it is preferable to send a > mail to the mailing list first to gather feedback on whether it is worth > working on before creating a PR. Thanks @dfuch , I've closed the PR and withdrawn the CSR. I'll make sure to check the mailing list first next time. Appreciate the guidance. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29882#issuecomment-3951141780
