On Fri, 6 Mar 2026 11:38:16 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find here a change that refactors >> `test/jdk/java/net/httpclient/http3/H3ErrorHandlingTest.java` to use JUnit. >> >> This fix also renames `QuicStandaloneServer::addHandler` to >> `QuicStandaloneServer::setHandler` - since the method doesn't add anything >> but simply sets a variable. >> >> Finally, it also sets up `test/jdk/java/net/httpclient/TEST.properties` to >> reject `testng` actions in jtreg tests under `test/jdk/java/net/httpclient`, >> since that was the last test that needed to be converted in this test >> hierarchy. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'master' into H3ErrorHandlingTest-8378569 > - Apply suggestions from code review > > Co-authored-by: Raffaello Giulietti <[email protected]> > - Update test/jdk/java/net/httpclient/TEST.properties > > Co-authored-by: Christian Stein <[email protected]> > - 8378569: Refactor > test/jdk/java/net/httpclient/http3/H3ErrorHandlingTest.java to use JUnit This looks good to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30079#pullrequestreview-3905079141
