On Mon, 23 Mar 2026 14:45:09 GMT, EunHyunsu <[email protected]> wrote:

>> Of course, that would also mean renaming the method to something like 
>> `parseExpires`.
>
> Thanks for the suggestion @jaikiran. I've refactored expiryDate2DeltaSeconds 
> into a static parseExpires method that returns the parsed Calendar, or null 
> on failure.
> 
> The delta calculation is now done at the call site.
> 
> Also removed the EXPIRY_DATE_PARSE_FAILURE constant, the unnecessary 
> try-catch around the expires handling, and updated the method comment and 
> B6791927.java @summary.

I know this is pre-existing logic but would it be hard to use `java.time` APIs 
instead of `Calendar`?
Could that method return an `Instant` instead of a `Calendar`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30341#discussion_r2987330354

Reply via email to