On Thu, 26 Mar 2026 11:18:25 GMT, serhiysachkov <[email protected]> wrote:

>> Update testng and junit tests to use diagnoseConfigurationIssue() method and 
>> post processing
>
> serhiysachkov has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains three commits:
> 
>  - 8380990: copyright format issue fix
>  - Merge branch 'master' into JDK-8380990
>  - 8380990: Update testng and junit tests to use diagnoseConfigurationIssue() 
> method and post processing

test/jdk/java/nio/channels/DatagramChannel/AfterDisconnect.java line 53:

> 51: import java.util.function.Predicate;
> 52: 
> 53: import org.testng.SkipException;

Can you sync up with @dfuch on this? He has a JBS issue created to create 
IPSupport methods that return a boolean or at least avoid need to use 
SkipException in JUnit tests (these tests have been converted to JUnit and I 
suspect your branch isn't up to date).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r2994118293

Reply via email to