On Wed, 1 Apr 2026 12:05:09 GMT, Michael McMahon <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Volkan's review - use -1 instead of 0 > > src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java > line 2044: > >> 2042: return invalidStatusLine; >> 2043: } >> 2044: final StringTokenizer st = new StringTokenizer(statusLine); > > Suggestion: > > final StringTokenizer st = new StringTokenizer(statusLine, " "); > > I know this is existing code (moved) but would it be better to create the > StringTokenizer with only " " (space) as delimiter, rather than the default > set of characters which includes various invalid control characters? Hello Michael, that's a good point. I hadn't paid attention to that part. I have now updated the PR to follow your suggestion and also updated the test to add coverage for this kind of status line response from the proxy. The test continues to pass with this change (and fails without this change for some of these additional added status lines). tier testing is currently in progress. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30466#discussion_r3026160263
