On Sun, 5 Apr 2026 13:55:44 GMT, Marcono1234 <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> test/jdk/java/net/SocketImpl/SocketImplCombinations.java line 136:
>
>> 134: Socket s = new Socket((SocketImpl) null) { };
>> 135: try (s) {
>> 136: assertTrue(getSocketImpl(s) == null);
>
> `assertNull`?
>
> (applies multiple times in this file; see other ` == ` checks)
Done
> test/jdk/java/net/SocketImpl/SocketImplCombinations.java line 153:
>
>> 151: try (s) {
>> 152: SocketImpl si = getSocketImpl(s);
>> 153: assertTrue(si instanceof CustomSocketImpl);
>
> `assertInstanceOf`?
>
> (applies multiple times in this file; see other ` instanceof ` checks)
Done
> test/jdk/java/net/SocketImpl/TestDefaultBehavior.java line 57:
>
>> 55: assertEquals(0, csi.supportedOptions().size());
>> 56:
>> 57: Assertions.assertThrows(NPE, () -> csi.setOption(null, null));
>
> Add static import for this?
Will be in next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3045551464
PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3045552883
PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3045546989
