On Tue, 14 Apr 2026 12:06:06 GMT, James Nord <[email protected]> wrote:
>> and attempting to force with >> ` bash configure --with-toolchain-type=gcc` yields >> >> >> configure: Toolchain type gcc is not valid on this platform. >> configure: Valid toolchains: microsoft. >> configure: error: Cannot continue. >> configure exiting with result code 1 >> >> >> This IS a linux platform :shrug: >> >> >> $gcc --version >> gcc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0 >> Copyright (C) 2023 Free Software Foundation, Inc. >> This is free software; see the source for copying conditions. There is NO >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. >> >> $lsb_release -a >> No LSB modules are available. >> Distributor ID: Ubuntu >> Description: Ubuntu 24.04.4 LTS >> Release: 24.04 >> Codename: noble > > --- a/make/autoconf/platform.m4 > +++ b/make/autoconf/platform.m4 > @@ -215,8 +215,8 @@ AC_DEFUN([PLATFORM_EXTRACT_VARS_FROM_OS], > VAR_OS_ENV=windows.cygwin > ;; > *wsl*) > - VAR_OS=windows > - VAR_OS_ENV=windows.wsl > + VAR_OS=linux > + VAR_OS_ENV=unix > ;; > *msys* | *mingw*) > VAR_OS=windows but that ultimately fails too. (this is too much onion peeling for me), I will just manually apply the feedback without validation if that is ok with everyone. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30074#discussion_r3079417049
