On Mon, 20 Apr 2026 09:06:29 GMT, Severin Gehwolf <[email protected]> wrote:
>> The concern here is that running `jlink` on a JEP 493 enabled JDK (no jmods) >> and on a JDK *with* JMODs give you the exact same custom runtime image. I.e. >> it has to include both preview and non-preview versions if both are present >> for a class. There is a test, >> `test/jdk/tools/jlink/runtimeImage/PackagedModulesVsRuntimeImageLinkTest.java` >> which tries to assert that. > >> David is working on an "end to end" test that will run jlink to create a >> run-time image that contains classes compiled with preview features enabled >> in META-INF/preview. Running a test with the resulting run-time image, both >> with preview features enabled and disabled, will ensure that it works as >> expected. It will need to be run with the default config, and builds that >> were configured with `--enable-linkable-runtime` of course. > > That's good. Thanks! Note that this is one of (at least) 3 PRs to integrate the feature, and some tests cannot reasonably exist until other code is added. Any TODOs in this PR are already addressed in the lworld branch which contains more tests. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3110955866
