On Fri, 24 Apr 2026 08:48:27 GMT, Severin Gehwolf <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix issue with resource lookup in ImageReader
>
> test/jdk/tools/jlink/JLinkPreviewTest.java line 60:
>
>> 58: * @run junit/othervm JLinkPreviewTest
>> 59: */
>> 60: public class JLinkPreviewTest {
>
> I needed this additional hunk for the test to work on linkable runtimes:
>
>
> diff --git a/test/jdk/tools/jlink/JLinkPreviewTest.java
> b/test/jdk/tools/jlink/JLinkPreviewTest.java
> index fcaa7493f07..d263c1ad972 100644
> --- a/test/jdk/tools/jlink/JLinkPreviewTest.java
> +++ b/test/jdk/tools/jlink/JLinkPreviewTest.java
> @@ -55,6 +55,7 @@
> * tests.*
> * @modules jdk.jlink/jdk.tools.jimage
> * jdk.jlink/jdk.tools.jlink.internal
> + * java.base/jdk.internal.jimage
> * @run junit/othervm JLinkPreviewTest
> */
> public class JLinkPreviewTest {
>
>
> Compilation of the test fails otherwise with:
>
> /disk/openjdk/upstream-sources/git/jdk-jdk/test/jdk/tools/lib/tests/JImageValidator.java:37:
> error: package jdk.internal.jimage is not visible
> import jdk.internal.jimage.BasicImageReader;
> ^
> (package jdk.internal.jimage is declared in module java.base, which does
> not export it to the unnamed module)
> /disk/openjdk/upstream-sources/git/jdk-jdk/test/jdk/tools/lib/tests/JImageValidator.java:38:
> error: package jdk.internal.jimage is not visible
> import jdk.internal.jimage.ImageLocation;
> ^
> (package jdk.internal.jimage is declared in module java.base, which does
> not export it to the unnamed module)
> 2 errors
>
> TEST RESULT: Failed. Compilation failed: Compilation failed
> --------------------------------------------------
Thank you for that!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3139057834
