On Wed, 6 May 2026 13:40:07 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this doc-only change which updates the >> specification of `Socket.isInputShutdown()` and `Socket.isOutputShutdown()` >> to clarify how it behaves when the `Socket` has been closed? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8310138. The commit in >> this PR merely specifies the current implementation. I'll create a CSR >> shortly. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Reword the shutdownInput/Output and isInput/OutputShutdown() methods > - merge latest from master branch > - merge latest from master branch > - link instead of linkplain > - improve the text > - 8310138 Socket.isInputShutdown and isOutputShutdown don't specify what is > returned when socket is closed The current wording is fine. Reading through the (mostly legacy) Socket API docs then there are many other opportunities to improve wording but all low priority and not for this PR. One small change for shutdownInput is to link "socket input stream" to Socket::getInputStream rather than changing it to "InputStream" in the PR, same thing in shutdownOutput where it can link to Socket::getOutputStream. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31000#issuecomment-4405579501
