On Wed, 13 May 2026 07:33:44 GMT, Jaikiran Pai <[email protected]> wrote:
>> Ashay Rane has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address PR comments >> >> 1. Use 'https' scheme with `.loopback()`, similar to other tests. >> >> 2. Drop reflection to access the connection and the cached header >> buffer. Instead add accessor methods to HttpClientImplAccess that >> fetch these members and use them in the tests. > > Thank you for the updates. I think the change is worth doing, but I haven't > had a chance to review the latest PR state, but will do so in the coming days. Thanks @jaikiran! I was under the (mistaken) assumption that increasing the header count would also increase the size of the cached buffer, but I see that the header count increases the number of frames instead. I've updated (and simplified) the test now. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/30931#issuecomment-4594330818
