On Wed, 1 Jul 2026 10:17:29 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this test-only change which proposes to remove > the `test/jdk/com/sun/net/httpserver/Test9a.java` test? > > When HttpServer was introduced long back, this test was introduced to cover > that newly introduced API through > https://bugs.openjdk.org/browse/JDK-6270015. > > When trying to address the current failure in this test as reported in > https://bugs.openjdk.org/browse/JDK-8355412, it was noticed that another test > `test/jdk/com/sun/net/httpserver/Test12.java` already tests what this > `Test9a` does. `Test9a` focuses on `https` server and fixed length responses > from the server. `Test12` does the same thing but additionally also tests > `http` and chunked mode responses. So `Test9a`, although it runs more threads > concurrently, there's no need to duplicate this testing between `Test12` and > `Test9a`. > > This PR removes the `Test9a` test (and retains `Test12`). > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). LGTM. I agree that removing Test9a looks like the best option. However if this is ever backported, care should be taken that Test12 in the release where the backport happen does cover what Test9a covers too. The analysis will have to be carried out again before applying the backport. ------------- PR Review: https://git.openjdk.org/jdk/pull/31736#pullrequestreview-4608057680
