On Tue, 7 Jul 2026 16:21:30 GMT, Benjamin Peterson <[email protected]> 
wrote:

>> Make `MinimalFuture` cancelation atomic. This prevents HTTP request 
>> cancelation logic from racily completing the future with an error.
>> 
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Benjamin Peterson has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   restore log

Still one problem to fix - the test doesnot compile :-)

test/jdk/java/net/httpclient/CancelRequestTest.java line 400:

> 398:             var cancelX = assertThrows(CancellationException.class, 
> cf1::get);
> 399:             out.println(now() + "Got expected exception: " + cancelX);
> 400:             assertThrows(cf1.isCancelled());

Suggestion:

            assertTrue(cf1.isCancelled());

-------------

PR Review: https://git.openjdk.org/jdk/pull/31758#pullrequestreview-4651961879
PR Review Comment: https://git.openjdk.org/jdk/pull/31758#discussion_r3542125292

Reply via email to