On Tue, 21 Jul 2026 07:59:41 GMT, Daniel Jeliński <[email protected]> wrote:
> Fix the test so that it exercises the max request time again. > > The test is supposed to check if the server closes the connection when it > receives some bytes from the client, but the bytes do not form a complete > request before the timeout elapses. Until recently, the server-side request > parser was looking for a CRLF sequence before checking if the received bytes > form a request, and the TLS handshake was a good enough approximation of an > incomplete HTTP request. > [JDK-8373677](https://bugs.openjdk.org/browse/JDK-8373677) modified the > parser to reject TLS early. > > This PR modifies the test to start sending a legal HTTP request, but stop > sending before the final CRLF sequence is sent, > > The test continues to pass. > > --------- > - [X] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This looks good to me. I just had a minor review comment which I've added inline. test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java line 112: > 110: } > 111: > 112: static String requestText = """ Nit - perhaps add a comment like `// Intentionally incomplete HTTP request`. Or maybe rename the field to `incompleteHttpRequest`. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31983#pullrequestreview-4743391392 PR Review Comment: https://git.openjdk.org/jdk/pull/31983#discussion_r3621158356
