On Fri, 31 Jul 2026 13:35:30 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which removes the `deregistrations` > field from an internal class of the `HttpClient`? > > As noted in https://bugs.openjdk.org/browse/JDK-8389514, this collection > never gets populated and as a result the call sites which `clear()` or > iterate over this collection are all dead code. It has been this way ever > since this field was introduced in Java 11 through > https://bugs.openjdk.org/browse/JDK-8197564. > > I'm running existing tests to verify that nothing breaks unexpectedly. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This pull request has now been integrated. Changeset: af4e9468 Author: Jaikiran Pai <[email protected]> URL: https://git.openjdk.org/jdk/commit/af4e9468d3bbbd95e9dc488c5aa3b7d65421dd1f Stats: 9 lines in 1 file changed: 0 ins; 8 del; 1 mod 8389514: HttpClientImpl$SelectorManager.deregistrations collection is always empty resulting in dead code Reviewed-by: dfuchs, djelinski ------------- PR: https://git.openjdk.org/jdk/pull/32152
