On Wed, 12 Aug 2026 11:13:16 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - merge latest from master branch >> - 8390186: [Valhalla] LoadNode::Value should check for ary->is_not_flat() >> >> Reviewed-by: thartmann, chagedorn >> - 8353624: C2: Re-enable malformed graph assert removed with JDK-8317998 to >> reduce noise >> >> Reviewed-by: qamai, thartmann >> - 8389671: (se) Blocking selection op in virtual thread does not keep spare >> alive beyond scheduler keep alive time (win) >> >> Reviewed-by: jpai >> - minor change to exception cause traversal >> - merge latest from master branch >> - fix major typo in test assertion >> - merge latest from master branch >> - add 8371903 to the test @bug ids >> - read incomingGoAway just once >> - ... and 2 more: https://git.openjdk.org/jdk/compare/fc05bab3...9baad557 > > src/java.net.http/share/classes/jdk/internal/net/http/Http2TerminationCause.java > line 234: > >> 232: // From the given exception's chain of causes, this method finds >> and returns an exception >> 233: // whose class type matches any of the given candidate types. >> Returns null if none found. >> 234: private static Throwable findInCause(final Throwable exception, > > Would it be worth adding this method to Utils and making sure it's use at the > other places where we look for a cause? I have that on my mind but didn't want to do that as part of this PR. I will run some experiments separately and if all tests continue to pass then I'll propose a separate PR to move this to Utils and reuse this or similar method from all relevant call sites. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32278#discussion_r3765914072
