On Fri, 28 Aug 2026 08:44:23 GMT, Volkan Yazici <[email protected]> wrote:
>> Lee Jiwon has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> 8390064: Stabilize IsAvailable test > > test/jdk/sun/net/www/http/HttpClient/IsAvailable.java line 125: > >> 123: // not consume data needed by the assertion. >> 124: assertEquals(-1, infra.readFromHttpClientSocket(), >> 125: "Expected EOF after closing the peer socket"); > > Suggestion: > > // Closing the server socket may not immediately be observable by > // the client. Read from the client's _internal_ socket to ensure > // that EOF, which is necessary for the `HttpClient::available` > // verification, has arrived. > assertEquals( > -1, infra.readFromHttpClientSocket(), > "Expected EOF after closing the server socket"); Thanks for the review, and sorry about the force-push. I addressed the comments in [a40d868](https://github.com/openjdk/jdk/pull/32539/commits/a40d868e98c69f6ef69a72d3c8b50f54496b4b11) and will use regular pushes from now on. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32539#discussion_r3880070987
