On Tue, 22 Sep 2026 06:50:01 GMT, Matthias Baesken <[email protected]> wrote:

>> src/java.base/windows/native/libjava/TimeZone_md.c line 72:
>> 
>>> 70:  * Calls RegGetValue to get the value for the specified key.
>>> 71:  * First tries the Unicode version, if that fails,
>>> 72:  * falls back to the ANSI version and converts to Unicode.
>> 
>> The fallback only made sense on non-Unicode Windows versions, the last of 
>> which was Windows ME. We should remove it, either here or in a follow up 
>> ticket. This method `getValueInRegistry` can be replaced with `RegGetValueW` 
>> then.
>
> Thanks for the comment and hint, I thought the same considering the comment 
> about the ancient Windows versions.
> Should we maybe do it in a follow-up issue ?

Follow up is fine by me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32987#discussion_r4069113481

Reply via email to