On Thu, 1 Oct 2026 13:14:11 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Adding new methods to `X509Certificate` to return `Instant` instead of >> `Date` as well as moving away from `Date` in internal packages wherever >> possible. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > Instant overflow fix src/java.base/share/classes/sun/security/util/DerOutputStream.java line 499: > 497: * 1/1/0001 is the lowest date representable by the GeneralizedTime > 498: */ > 499: private static final Instant generalizedLow = > Instant.ofEpochSecond(-62135596800L); I heard it's 1/1/0000, although that means 1 BCE. Also, you should add HH:mm:ss to the comments. Or, just use the GeneralizedString format, i.e. 00000101000000Z. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r4160850282
