On Mon, 12 Oct 2026 12:55:14 GMT, Matthias Baesken <[email protected]> wrote:
> `src/java.base/windows/native/libnet/ResolverConfigurationImpl.c` has 3 > unused macros defined: `IS_SL_FOUND`, `IS_NS_FOUND`, and `STS_NO_CONFIG`. > > Plus, `loadConfig()` returns `STS_SL_FOUND & STS_NS_FOUND`, which is always > 0. `&` usage looks wrong. > However the strange return value is no big issue because we currently only > check for error (-1), and this still works. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Could you make `loadConfig` return a BOOL instead? It sounds more adequate, and would get rid of the remaining macros. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33318#issuecomment-6139543580
