On Mon, 19 Oct 2026 17:26:25 GMT, Daniel Fuchs <[email protected]> wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 219: >> >>> 217: // there is no point in pulling the data. >>> 218: // if bodyCf is null just stop here; this is not >>> expected. >>> 219: if (bodyCf == null || bodyCf.isCancelled() || >>> bodyCf.isCompletedExceptionally()) break; >> >> Can you add a comment stating when we actually want to continue the loop >> despite errorRef being non-null? > > As long as we haven't processed all the buffered data? This is HTTP/2 so it > is impossible to know whether you have received all the data before > processing it. ok, what's the point of the errorref check then? Is it just to avoid the costly getBody call? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33385#discussion_r4316983513
