On Mon, 26 Oct 2026 10:10:00 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/java/net/URI/Test.java line 1426:
>>
>>> 1424: * {@code >}, {@code =}, and {@code !=}.
>>> 1425: */
>>> 1426: private static void eqHashCompBid(Object s, Object t, String
>>> expectedRelation)
>>
>> Nit - I think it would be better to change the method to accept only `URI`
>> instances, instead of `Object`, and then have the call sites convert the
>> `String` to `URI`.
>
> Another nit - instead of `expectedRelation` being a `String`, perhaps make it
> a `enum`?
Maybe rename the method to `eqHashCompBidi`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33232#discussion_r4376062314
