On Tue, 17 Nov 2026 20:33:20 GMT, Ashay Rane <[email protected]> wrote:

>> Update the NTLM challenge used in tests.
>> 
>> The new challenge was generated on a Windows 11 machine using the 
>> `AcceptSecurityContext` function, then manually minified by shortening 
>> domain and machine names to a single character.
>> 
>> The modified tests pass with the change, fail without it. They pass even on 
>> Windows 11 and Windows 2025 after removing the `@requires` line.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Hi Daniel, I see that (after reverting 4d9e49a) on machines that have NTLM 
> credentials, your patch fixes the problem, but on machines that are joined to 
> Entra ID (instead of a domain), the "NTLMHeadTest PROXY" test and the 
> "TestTransparentNTLM transparentAuth=allHosts" test fail.  So I see the 
> utility of this patch, but I'm not sure if we can revert the older commit.

Thanks @raneashay for checking. It's interesting that these particular cases 
fail (`NTLMHeadTest PROXY` failing suggests that `NTLMHeadTest SERVER` 
succeeded first). I won't touch the `requires` lines then.

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33934#issuecomment-6971782180

Reply via email to