Hi, Jochen.
I think the Net-SNMP community would benefit from the patches that are currently held in net-snmp-5.1.2-5.diff.gz. [Search "debian" and "net-snmp" to find that file]
I believe that some of those patches could be applied to the V5-1-patches and main branches of net-snmp CVS trees.
The patches suitable for adding to CVS tree of Net-SNMP should be BSD-like license friendly. The portions which are not should be removed from the patch list that you would like to consider for incorporation into Net-SNMP.
Please review this assessment and advise which patches can be applied to net-snmp CVS tree. Also, please tell us which patches fix bugs, as those can also be applied to the V5-1-patches branch.
Most important, let us know which patches should not be applied. It would be nice to know why, if that information can be shared.
Thanks for your patience and assistance, -Mike Slifcak
1.Remove SO_BSDCOMPAT socket option setting from snmplib/snmpUDPDomain.c and from snmplib/snmpUDPIPv6Domain.c
These were useful only in Linux 2.0 kernels ? Seems low risk and appropriate. Comments ?
2.Add -lcrypto if defined as part of CRYPTOLIBS configure.in snmplib/Makefile.in
Seems low risk and appropriate. Comments ?
3.Move assignment to newline later in function snmplib/snmp_logging.c [NOT DONE]
Looks like nothing is accomplished here. Suggest not applying this patch.
4.Remove CR character from Windows specific resources net-snmp-5.1.2/snmplib/winservice.rc [NOT DONE] net-snmp-5.1.2/snmplib/winservice.mc [NOT DONE]
What impact are they having on Debian Linux builds? They become useless when this is done. Suggest not applying this patch.
5.Add perlrealclean rule to top level Makefile Makefile.in
Suggest to accomplish this from a distclean rule: @(cd perl; make realclean) Comments?
6.Add WRAPLIBS to several Makefiles agent/Makefile.in net-snmp-config.in
This looks like completing work done throughout the project. Suggest applying this patch.
7.Create Debian specific changes to Makefiles agent/Makefile.in AGENT_RELINK_LIBS, MIBS_RELINK_LIBS agent/helpers/Makefile.in HELPERS_RELINK_LIBS apps/Makefile.in TRAPD_RELINK_LIBS
Why dont these simply add WRAPLIBS ? I think these are too specific to Debian. Comments?
8.Comment out "No MemShared line in /proc/meminfo" in agent/mibgroup/ucd-snmp/memory.c
Which bug does this fix?
9.Various LmSensors changes [NOT DONE] agent/mibgroup/ucd-snmp/lmSensors.c already applied memleak and limit check fixes MIB object changes (Gauge to Integer) violate RFC 1902 mibs/LM-SENSOR-MIB.txt MIB object changes (Gauge to Integer) violate RFC 1902
10. Add C99 macros to format result strings for 64-bit counters agent/mibgroup/mibII/interfaces.c [NOT DONE]
Already applied [Please confirm]
11.Patch to ignore interfaces that have no statistics agent/mibgroup/mibII/interfaces.c
Is there documentation change needed? Seems low risk and appropriate. Comments ?
12.Patch to log level Error -> Debug when printing data format error agent/mibgroup/mibII/interfaces.c
This doesn't seem right. Comments ?
13.Don't log peer password in authentication log messages agent/mibgroup/smux/smux.c
Seems low risk and appropriate. Comments ?
14.Change location of default AgentX socket in agent/mibgroup/agentx/protocol.h "/var/agentx/master" -> "/var/run/agentx"
Tradition. Comments ?
15.Insert blank line after __END__ in dummy Perl module agent/netsnmp_request_infoPtr.pm
Seems low risk and appropriate. Comments ? Would it be appropriate to do so for all *.pm files ?
16.Provide interesting sample configuration file EXAMPLE.conf.def
Would be nice. Are these changes suitably licensed (BSD-like) ?
17.Perl command addition to substitute /usr/local/etc/snmp for SNMPCONFPATH in
local/Makefile.in
Seems low risk and appropriate. Comments ?
18.Include /etc/snmp in def_search_difs local/mib2c
With change (keep other line referencing /usr/local/etc/snmp), Seems low risk and appropriate. Comments ?
19.Terminate if search past last if_table entry, indicates response from server is inconsistent apps/snmpnetstat/if.c
Seems low risk and appropriate. Comments ?
20.Add sysconfdir to Makefile.top
Seems low risk and appropriate. Comments ?
21.Add HAVE_DLOPEN acconfig.h configure.in
Seems low risk and appropriate. Comments ?
22.FAQ changes /usr/local --> /usr
23.Seven new MIBs and one existing MIB are installed mibs/LM-SENSORS-MIB.txt (existing) mibs/Makefile.in mibs/OSPF-MIB.txt mibs/RIPv2-MIB.txt mibs/BGP4-MIB.txt mibs/BRIDGE-MIB.txt mibs/OSPF-TRAP-MIB.txt mibs/SOURCE-ROUTING-MIB.txt mibs/GNOME-SMI.txt
Why GNOME-SMI added ? Other MIBs (except LM-SENSORS-MIB) *should* be obtainable from IETF MIB repository. Comments?
24.Allow for non-positive sensor values in LM-SENSORS-MIB and change existing Temperature, Voltage, and Miscellaneous sensor value types from Gauge to Integer.
Violates RFC 1902. Not done here. MIB rewrite later.
25.configure.in --without-rpm Don't use RPM even if available. Add -lcrypto if EVP_md5 is available in crypto library Add -ldl if dlopen function is defined Modify HAVE_SSIZE_T to provide value "1"
Seems low risk and appropriate. Comments ?
26. Hard code DATADIR to /etc/snmp [NOT DONE] man/mib2c.1.def
27. Man page changes, relatively minor man/mib_api.3.def man/snmp_trap_api.3.def man/snmp_config.5.def <--NOT DONE
28. Add "-- core" to clean rule in Makefile.rules
Why ?
29. Add Debian build subdirectory [NOT DONE]
Will leave to Debian packaging authority
30. Add sample configuration file for trap handler
This file acts as an empty file (no configure settings)
EXAMPLE-trap.confWould be nice. Are these changes suitably licensed (BSD-like) ?
------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Net-snmp-coders mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
