On Wed, 24 Nov 2004 09:57:44 +0100, P K <[EMAIL PROTECTED]> wrote:
> On Wed, 17 Nov 2004 12:55:34 -0500, Coders Robert Story
> <[EMAIL PROTECTED]> wrote:
> > On Tue, 16 Nov 2004 13:29:30 +0100 P wrote:
> > PK> 1) I wrote some mib and then generated code using mib2c with mfd.
> >
> > Aha, my first victim!
>
> :)
So there is rest of the story:
Bacckground: I have some table that support row creation and destroy.
My suggestions:
1)
When I'm seting value (variable type is OCTET STRING(SIZE(0..16) ) to
empty string ( snmpset ... = '' ) i've got:
snmpd: isdnTable/trbIsdnTable_data_set.c:2531: trbIsdnMaster_check_value:
Assertion `((void *)0) != trbIsdnMaster_val_ptr' failed.
it's in function:
int trbIsdnMaster_check_value(trbIsdnTable_rowreq_ctx * rowreq_ctx,
char *trbIsdnMaster_val_ptr,
size_t trbIsdnMaster_val_ptr_len)
2)
I got some sigsev's after deleting table row. I've changed
if (rowreq_ctx->undo)
trbIsdnTable_release_data(rowreq_ctx->undo);
to
if (rowreq_ctx->undo){
trbIsdnTable_release_data(rowreq_ctx->undo);
rowreq_ctx->undo = NULL; // PK
}
in trbIsdnTable_release_rowreq_ctx(trbIsdnTable_rowreq_ctx * rowreq_ctx)
in _interface.c and it works well, but I'm unsure if it's only workaround or
bugfix.
3)
in xxx_data_set, in commit function there is:
if (save_flags & FLAG_TRBISDNEAZ) {
I think tehere should be reather:
if (!rc && save_flags & FLAG_TRBISDNEAZ) {
so if one failed we do not commit others.
In this solution there should also be
if (!rc && save_flags) {
instead of
if (save_flags) {
at the end of this function.
Greetings,
Pawel
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
Net-snmp-coders mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
