On Wed, 23 Feb 2005 14:35:31 -0500 Olsson, wrote: OS> RS> Good idea. I only see a few minor changes, but I don't see why this OS> RS> couldn't make it into 5.3. OS> Cool. If you let me know I can make the changes and resubmit the patch.
Let's see.. - fd_event_manager -> external_fd_manager - netsnmp_external_event_info -> netsnmp_external_fd_info - netsnmp_dispatch_external_events -> netsnmp_external_fd_read Also, you changed the priority such that external events are handled before snmp events. The order shouldn't change. In snmptrapd.c you zero writefds twice and execeptfds isn't cleared. I think those are the only problems. However, I also have suggestions, if you are feeling ambitious. - adding or deleting fds (external and internal) is controlled, so the fd_sets could be cached, instead of looping all the time. - the routine agent_check_and_process, which is provided for use with subagents, doesn't deal with external events at all. - It wouldn't take too much more work to eliminate 'external' and just make a general fd_manager, which would eliminate a little more redundant code from snmpd and snmptrapd. I'll respond the the trap stuff in another thread... -- Robert Story; NET-SNMP Junkie Support: <http://www.net-snmp.org/> <irc://irc.freenode.net/#net-snmp> Archive: <http://sourceforge.net/mailarchive/forum.php?forum=net-snmp-coders> You are lost in a twisty maze of little standards, all different. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
