Correct.
1) solves our intial problem, since we're "linux" and not "sunV3".
2) came out while I was looking for 1). If you look at the code (or
the diff) you'll notice that the only thing you ever really do with
if_unit is to "string_append_int()" or "strncat()" it to if_name
before the result is passed on.
So, why keep it? Because of 1) for "sunV3 && !linux"?
>What differences do you see in MIB output with and without
>the if_unit handling?
None.
Anyway, I don't have a problem if you pick 1) and not 2).
Gunnar
PS
Ooops, almost none :-). Debug output changes:
Before any change:
mibII/interfaces: * see: known interfaces:
lo dummy tunl gre sit eth eth eth eth eth eth
Assuming we do 1) only:
mibII/interfaces: * see: known interfaces:
lo dummy tunl gre sit eth eth eth eth eth eth ip
With 1 & 2):
mibII/interfaces: * see: known interfaces:
lo dummy0 tunl0 gre0 sit0 eth0 eth1 eth2 eth3 eth4 eth5 ip6tnl0
DS
>From [EMAIL PROTECTED] Fri Jun 10 11:36:59 2005
>Subject: Re: "diff -c" Linux 2.6 IPv6 interface "ip6tnl0"
>From: Dave Shield <[EMAIL PROTECTED]>
>To: Gunnar Lindberg <[EMAIL PROTECTED]>
>Cc: [email protected]
>In-Reply-To: <[EMAIL PROTECTED]>
>References: <[EMAIL PROTECTED]>
>Organization: University of Liverpool, Computer Science
>Message-Id: <[EMAIL PROTECTED]>
>Date: Fri, 10 Jun 2005 10:33:43 +0100
>On Fri, 2005-06-10 at 09:35, Gunnar Lindberg wrote:
>> Here we go. Two "diff -c" below. They fix:
>>
>> 1) 'if (strcmp(saveName, "ip") == 0)'
>> Now put back into the original "#ifdef sunV3" (and only that).
>I've applied this to the main CVS code base and the 5.2.x line.
>I welcome comment as to whether it's appropriate for 5.1.x.
>> 2) The whole notion of (ifnet *)->if_unit is removed.
>> The entire interface name is now in (ifnet *)->if_name.
>Is this patch actually needed?
>I got the impression that it was the "off-by-one" indexing
>that was causing you difficulties? Doesn't removing the "ip"
>check fix that problem?
>What differences do you see in MIB output with and without
>the if_unit handling?
>Dave
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
