On Tue, 2006-02-14 at 12:44 -0500, Robert Story wrote:
> DS> Can you give me an executive summary, please Robert.
> 
> Did you check the summary in the patch?

I'd read the tracker comments, but didn't get around to
downloading the patch itself.

>                           I was rather verbose. Maybe that's why
> you asked for an 'executive' summary. I'll try to make it shorter.
> 
> - override handler works *after* the fact. original handler is called and
> returns data.
> 
> - bulk_to_next handler advances to next variable if data was returned. didn't
> check if data was out of range.
> 
> - check_getnext_results noticed the override after the fact, set type to
> retry, and set the inclusive flag.
> 
> - instance handler will return the object queried (ala get) for a get-next
> request.
> 
> - bulk_to_next uses 1 request obj w/multiple varbinds. once the inclusive flag
> is set by check_get_next_results, it's never cleared.
> 
> These all combined to cause the issues noted in the original bug (original &
> overridden data returned w/getbulk, and the endless loop I found while testing
> table instance overrides (Radek's test case).

OK - That's a good clear explanation.


> The patch fixes both cases.

Ummm...
I've had a quick look at the patch, but I'm not totally clear on
exactly how it works and what the implications are.   (I'm still
slightly under the weather from last weekend, I think).


>  The only part that I'm a little worried about is
> the inclusive flag changes.

The thing that I'm a little worried about is the mention in "note.txt"
about "the wrong handler chain .. being set up initially".   I'm not
sure if your patch addresses that, but it would seem to warrent further
investigation.

How exactly are you setting the agent up to trigger this problem?



> [I'll suppress the rant on how I want to totally gut the agent processing code
> and make it into something more understandable and easy to follow. At least
> until the next time I get sucked in that code.]

And I'll suppress the similar rant triggered whenever I look at the MfD
internal files :-)    Not least because I *did* put together something
more understandable and easier to follow  :-) :-)

Dave


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to