On Tue, 27 Jun 2006 13:34:19 -0400 Robert Story <[EMAIL PROTECTED]> wrote:
> On Tue, 27 Jun 2006 20:45:08 +0400 Konstantin wrote: > KA> There is state "row create" in chart of SET processing for baby steps > KA> (drown in file agent/helpers/baby_steps.c, lines 140-204). According to > KA> this chart, it activates if lookup failures. But, mode > KA> MODE_BSTEP_ROW_CREATE activates in case of success of previous lookup, but > KA> there are no respective callback 'row_creation' for all tables, supported > KA> with "baby steps" scheme. > KA> ... > > Your analysis is spot on. It's been a while since I wrote all that code, so > it's probably the case that I started working on tables that didn't support > row creation, and thus didn't use the row creation callback. When I moved on > to the row creation table, I probably had forgotten about that state. > > I think the correct fix will be to use the row creation state, but this will > require a change in the baby steps flow, to allow it to progress to the next > step even when there are 'errors' in the lookup phase. I wrote good state machine support for baby-steps flow (in any case, it was neccessary for me) and can suggest this patch. It correctly works with current functionality of callbacks (when row creation done while object_lookup) and with separate row_creation callback. Should I send it here? It is not very small - about hundred of lines.. By the way, I can suggest support of read/write/create for Route tables via netlink library. -- Konstantin V.Abramenko OKTET Labs. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
