>>>>> "RS" == Robert Story <[EMAIL PROTECTED]> writes:
RS> If the logging caused a problem, then that's a bug that should be RS> fixed. Doing it as an assert is wrong. Especially since the code right above it makes the assert always trigger. I stared at that code for 5 minutes this morning (before I did an update and happily noticed it was gone) and couldn't figure out why the heck someone had written it that way. A minimum it should have a comment above it saying you expect it always to hit. But I agree with Dave, that's not an assert kind of need... Log it or something else. Assert seems totally wrong there. [I'm very tempted to get on my assert soapbox saying that all the asserts in net-snmp are bad and evil because they're doing nothing more than saying "I refuse to more error checking than letting you know I know it'll be an error but I refuse to properly bail out of it". But I won't go on that soap box. No not me. nope.] -- Wes Hardaker Sparta, Inc. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
