Robert Story wrote: > On Fri, 25 Aug 2006 14:07:22 +0200 Thomas wrote: > TA> apps/snmptrapd_auth.c:netsnmp_trapd_check_auth() in 5.3+ is implemented as > TA> > TA> int netsnmp_trapd_check_auth(int authtypes) > TA> > TA> but gets called as > TA> > TA> netsnmp_trapd_check_auth(traph->authtypes, pdu) > TA> > TA> in apps/snmptrapd_handlers.c which we didn't notice because there wasn't > TA> even a prototype for netsnmp_trapd_check_auth() in > TA> apps/snmptrapd_auth.h. Now that I added it, the build fails, of course. > TA> > TA> Are we going to > TA> > TA> a) adjust the caller to say netsnmp_trapd_check_auth(traph->authtypes) > TA> b) extend the prototype for a second argument (pdu) to be able to use it > TA> in the future (e.g. for storing lastlookup) > > I think a is the only option. b is an API change, and thus requires a library > version bump. If we need the pdu later, we can add a new function.
Not sure it'd be a change of the public API since netsnmp_trapd_check_auth() hasn't been in any header file before, although probably by accident. It now is, as well as option a. +Thomas -- Thomas Anders (thomas.anders at blue-cable.de) ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
