Wes Hardaker wrote: >>>>>> "TA" == Thomas Anders <[EMAIL PROTECTED]> writes: > > Err, the one thing that worries about this patch is that you're hard > coding block size values in various places: > > TA> + mem->size = meminfo.physmem + (swaptotal*512/pagesz); > ^^^ > and in: > > TA> + mem->units = 1024; > TA> + mem->size = swaptotal/2; /* blocks to KB */ > TA> + mem->free = swapfree/2; /* blocks to KB */ > mem-> other = -1; > > Any chance you can actually pull the numbers from somewhere on the > system instead?
1) I'm not aware the block size can ever be different than 512. 2) I wouldn't know where to pull it from. 3) I'm not pretending to be better than "top" which hard codes it as well. +Thomas -- Thomas Anders (thomas.anders at blue-cable.de) ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
