On 26-Oct-2006, at 4:27 PM, Wes Hardaker wrote:

The patch below fixes the problem stated in patch #1578339 but in a
different way (IE, the way we've been doing it in the past).  But now
rather than creating a zillion .so files in CVS, the makefile
generates them and cleans them up...  A bit more efficient.  However,
the patch below *only* does this for the new files as I'd like to have
it considered for 5.4 and was trying to minimize changes...  Thus the RFV.

Thank you for putting this together, Wes; I'm sorry I didn't have the time before I left.

I think you missed a dependency, tho:

Index: Makefile.in
===================================================================
RCS file: /cvsroot/net-snmp/net-snmp/man/Makefile.in,v
retrieving revision 5.27
diff -u -p -r5.27 Makefile.in
--- Makefile.in 2 Dec 2005 15:33:42 -0000 5.27
+++ Makefile.in 26 Oct 2006 23:26:49 -0000
@@ -185,6 +231,8 @@ maninstall:  maninstalldirs $(MAN1) $(MA
  @for i in $(MAN3) ; do $(INSTALL_DATA) $(srcdir)/$$i $(INSTALL_PREFIX)$(man3dir) ; echo "install:  installed $$i in $(INSTALL_PREFIX)$(man3dir)" ; done
  @$(INSTALL_DATA) $(MAN3G) $(INSTALL_PREFIX)$(man3dir)
  @for i in $(MAN3G) ; do echo "install:  installed $$i in $(INSTALL_PREFIX)$(man3dir)" ; done
+ @$(INSTALL_DATA) $(MANALIASES) $(INSTALL_PREFIX)$(man3dir)
+ @for i in $(MANALIASES) ; do echo "install:  installed $$i in $(INSTALL_PREFIX)$(man3dir)" ; done
  [EMAIL PROTECTED](INSTALL_DATA) $(MAN5G) $(INSTALL_PREFIX)$(man5dir)
  @for i in $(MAN5G) ; do echo "install:  installed $$i in $(INSTALL_PREFIX)$(man5dir)" ; done
  @$(INSTALL_DATA) $(MAN8G) $(INSTALL_PREFIX)$(man8dir)

Whatever the "maninstall" target is dependent upon the individual man pages, but not the aliases. I recommend adding "manaliases" as a dependency until such time as we can clean it up and use a more direct creation method, i.e
$(SNMP_ALARM_ALIASES): man3/snmp_alarm.3
echo "making man page alias $@ from snmp_alarm APIs"
echo ".so man3/snmp_alarm.3" > $@

--chris
net-snmp-owners at group.apple.com



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to