On 06/11/06, Robert Story <[EMAIL PROTECTED]> wrote: > DS> I therefore offer the following patch which: > DS> - reports the amount of memory used rather than free, > DS> - introduces new MIB objects with consistent names/descriptions > DS> - deprecates (but retains) the inconsistent MIB objects. > > I was under the impression, from a more recent thread, that these were not the > only objects that would be a behaviour change from 5.3.x.
I'm currently in the process of analysing exactly which objects might be affected. But Wes has been nagging me for *years* to commit changes little-and-often. I do occasionally listen to him :-) There may well be other objects that will need addressing - but I *know* these two do. > DS> - case MEMORY_STXT_AVAIL: /* XXX - Or used ? */ > DS> + case MEMORY_STXT_AVAIL: > DS> + case MEMORY_STXT_USED: > DS> + /* > DS> + * The original MIB description of memAvailSwapTXT > DS> + * was inconsistent with that implied by the name. > DS> + * Retain the actual behaviour for the (sole) > DS> + * implementation of this object, but deprecate it in > DS> + * favour of a more consistently named replacement object. > DS> + */ > > It would be nice if the comment indicated which of the case labels was the > deprecated case. Or maybe add /* deprecated* after the label itself? Fair enough. That's easy enough to tweak. > DS> - case MEMORY_RTXT_AVAIL: /* XXX - Or used ? */ > DS> + case MEMORY_STXT_AVAIL: > DS> + case MEMORY_STXT_USED: > > Shouldn't both of these additions be RTXT? Yes. Good catch. > And ditto my above comment on the comments. Ditto response. Dave ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
