I've finished analysing the new HAL-based ucd-snmp/memory module, and comparing it against the previous individual statistics.
There are [a couple of] areas where the code is non-trivially different:
- memTotalFree
- memSwapError{,Msg}
I offer the attached patch for consideration w.r.t. these two areas. It's a little larger than I'd ideally like at this late stage in the release cycle, but I believe that it's still worth considering it for 5.4. This feels the right release to make these changes - rather than waiting till 5.5. The first half is mostly clarifications to the UCD MIB file, to make the behaviour of these particular objects more explicit. I've also introduced a new Textual Convention, to clarify the range of valid values for the error flag. I believe this falls within the spirit of RFC 2578 (10.2, clause (2)) The second half is tweaking the code for these objects. In most cases, this doesn't actually affect the values returned at all - it just implements things in a somewhat clearer manner. (That's clearer as in more explicit, rather than necessarily simpler code. In particular, it avoids a reliance on implicit dependencies within the HAL memory module). This does slightly amend the behaviour on *BSD systems, where these objects have up to now been tracking free swap only (rather than swap+real). I recognise that any change of behaviour is unwelcome, but I suggest that the benefits of a clear and consistent approach outweigh any disadvantages. In particular, I very much doubt that a system which is running short of swap will have significant amounts of memory still free. And if it did, then it's probably not actually in an error state anyway. Anyway - here's the patch for your perusal. It's almost certainly less of a clear-cut decision than some of the other RFVs recently - so it would be useful to have as much input as possible. Not just the usual suspects :-) Dave
mem_error.diff
Description: Binary data
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
