Dave Shield wrote: > Updated patch attached A few initial minor remarks. Don't have time for a full review atm.
> ucdavis MODULE-IDENTITY > - LAST-UPDATED "200611070000Z" > + LAST-UPDATED "200611220000Z" > ORGANIZATION "University of California, Davis" > CONTACT-INFO > "This mib is no longer being maintained by the University of > @@ -53,6 +53,9 @@ > email: [email protected] > " > DESCRIPTION > + "Clarify behaviour of objects in the memory & systemStats groups." > + REVISION "200611220000Z" > + DESCRIPTION > "Clarify behaviour of mem*Text objects (& provide updated versions)." > REVISION "200611070000Z" Merge both pre-5.4 changes into *one* REVISION because they haven't been published yet? > memAvailSwapTXT OBJECT-TYPE [...] > STATUS deprecated [...] > + for use. For clarity, this object is being deprecated > in favour of 'memUsedSwapTXT(16)." Rather say "has been deprecated" given the STATUS above? > memTotalFree OBJECT-TYPE > SYNTAX Integer32 > + UNITS "kB" > MAX-ACCESS read-only > STATUS current > DESCRIPTION > - "Total Available Memory on the host" > + "The total amount of memory free or available for use on > + this host. This value typically covers both real memory > + and swap space or virtual memory." > ::= { memory 11 } The last sentences has a slight ambiguity wrt. "(real memory and swap space) or (virtual memory)" vs. "(real memory) and (swap space or virtual memory)". Have you run the final MIB (after the patch) through smilint? +Thomas -- Thomas Anders (thomas.anders at blue-cable.de) ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
