>>>>> "DS" == Dave Shield <[EMAIL PROTECTED]> writes:
DS> On 11/05/07, Thomas Anders <[EMAIL PROTECTED]> wrote: >> Dave Shield wrote: >> > OK - I think I've submitted an appropriate fix for the 5.2.x and 5.3.x >> > lines. >> > This follows the coding style of the previous (inadvertently deleted) code, >> > rather than the newer structure of the 5.4.x line. >> >> Did you copy-n-paste manually? Isn't this code meant to be fully >> auto-generated (by "gen")? DS> a) I don't know - ask Wes. Sorry, was gone at the end of last week which caused typical mail backlog. DS> b) The 5.4.x version seems to be auto-generated. yep. they all have been for a while. sometimes I'm not sure it's a good thing, but the theory seemed sound. DS> There's no indication that the equivalent code in the earlier lines were. They should have been too (hence the "gen" script in all of them). DS> c) The Luddite in me suspects that running "gen" might have been the DS> cause of the problem in the first place. likely. DS> d) If you want to replace this patch with gen-generated code, go DS> right ahead. ideally, that would be a good thing. DS> e) If the code works, who cares? I haven't compared what you did against the generated code, but the generated .xs file is a nasty state machine. I'm not sure you did something equivalently nasty. -- Wes Hardaker Sparta, Inc. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
