We're currently installing agent/snmp_perl.pl and
apps/snmp_perl_trapd.pl as executables (mode 755), although they are
not. They're used by snmpd/snmptrapd to initialize embedded Perl
support. They *can not* be used as standalone scripts.

rpmlint correctly complains about these files being installed as
executable scripts without a shebang line. This causes problems for
packagers (like darix).

The attached trivial patch makes sure these files get installed with
mode 644 instead of 755 (that's the only difference between $(INSTALL)
and $(INSTALL_DATA), see the top-level Makefile after having run
configure if you want to double-check).

I'm calling for votes to apply this to 5.4.1.


+Thomas

Index: apps/Makefile.in
===================================================================
--- apps/Makefile.in	(Revision 16583)
+++ apps/Makefile.in	(Arbeitskopie)
@@ -154,7 +154,7 @@
 	rm -f $(INSTALL_PREFIX)$(bindir)/snmpinform$(EXEEXT)
 
 snmptrapdperlinstall: installdirs
-	  @$(INSTALL) $(srcdir)/snmp_perl_trapd.pl $(INSTALL_PREFIX)$(snmplibdir)/snmp_perl_trapd.pl
+	  @$(INSTALL_DATA) $(srcdir)/snmp_perl_trapd.pl $(INSTALL_PREFIX)$(snmplibdir)/snmp_perl_trapd.pl
 	  @echo "install:  installed snmp_perl_trapd.pl in $(INSTALL_PREFIX)$(snmplibdir)"
 
 snmptrapdperluninstall: installdirs
Index: agent/Makefile.in
===================================================================
--- agent/Makefile.in	(Revision 16583)
+++ agent/Makefile.in	(Arbeitskopie)
@@ -158,7 +158,7 @@
 
 embedperlinstall:
 	  @$(SHELL) $(srcdir)/../mkinstalldirs $(INSTALL_PREFIX)$(snmplibdir)
-	  @$(INSTALL) $(srcdir)/snmp_perl.pl $(INSTALL_PREFIX)$(snmplibdir)/snmp_perl.pl
+	  @$(INSTALL_DATA) $(srcdir)/snmp_perl.pl $(INSTALL_PREFIX)$(snmplibdir)/snmp_perl.pl
 	  @echo "install:  installed snmp_perl.pl in $(INSTALL_PREFIX)$(snmplibdir)"
 
 embedperluninstall:
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to