On 13/07/07, Wes Hardaker <[EMAIL PROTECTED]> wrote:
> >>>>> "TA" == Thomas Anders <[EMAIL PROTECTED]> writes:
>
> TA> -coders subject was "Re: rfv: remove asserts with undefined string
> TA> comparisons". I'm attaching it here again for convenience.
>
> Ugh. -1.
>
> How about a counter proposal, since I don't think that patch is
> necessarily any purer (it is still comparing strings)...
Err.... no, it's not.
The assertion is a single string (not a comparison).
> Change those lines to debugging statements and assert that 1 != 0
> instead to get it to stop.
I'm not convinced by the use of assertions as a debugging tool either.
I would also prefer to see these situations handled via debugging output.
However, I don't believe that RC-status is the time to introduce such
a change.
In principle, I'm inclined to support your proposed patch, but not
at this stage of the release cycle. The code currently includes
(possibly broken) assertions, so the correct fix at this stage is to
apply as minimal-impact patch as possible.
If switching from
assert( "string1" == "string2" )
to
assert( !"string == string2" )
has the required behaviour, then that's probably the sensible
change to apply at the moment.
If we want to move towards a debug-based approach (either within
an assertion-style framework, or replacing them altogether), then
fine - but that's a later discussion, not a last-minute RC issue.
All IMO, of course.
Dave
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
