On Mon, 2008-04-14 at 23:14 +0200, Magnus Fromreide wrote: > On mån, 2008-04-14 at 13:57 +0100, Alex Bennee wrote: > > Hi, > > > > As noted in earlier messages the sizeof(oid) on a 64 bit machine is 8 > > bytes due to the use of u_long. This patch ensures that an oid is always > > 32 bit by using the uint32_t type instead. > <snip> > We are using autoconf to ensure that uint32_t is available nowadays, so > I think the definition of oid should be simplified even further to > > typedef uint32_t oid;
Indeed. I was being mindful of the places that may use the library with less than standard libc's/C compilers. Having said that the types are C99 so you would hope everything has them by now (unless it's a very weird arch). In fact I see the trunk has had a bunch of the old #ifndef HAS_x compatibility stuff removed from types.h. If we are happy that net-snmp relies on guarantees made by autoconf about the system then I shall forward a simplified patch. -- Alex Bennee, Software Engineer Let us not look back in anger or forward in fear, but around us in awareness. -- James Thurber ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
